Use std::filesystem::path in DerivationBuilder
#14800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
with-tests
Ericson2314
force-pushed
the
std-file-system-path-in-builder
branch
from
aed78a6 to
496e8e2
Compare
xokdvium
reviewed
Dec 22, 2025
xokdvium
reviewed
Dec 22, 2025
xokdvium
reviewed
Dec 22, 2025
Ericson2314
force-pushed
the
std-file-system-path-in-builder
branch
from
496e8e2 to
9ef60a7
Compare
Since it is currently unix-only, we can use `.native()` not `.string()` for perf, and we don't have to worry about platform-specific conversions.
Ericson2314
force-pushed
the
std-file-system-path-in-builder
branch
from
9ef60a7 to
04c0e34
Compare
xokdvium
approved these changes
Jan 4, 2026
Contributor
xokdvium
reviewed
Jan 5, 2026
| if (!cgroupFS) | ||
| throw Error("cannot determine the cgroups file system"); | ||
| auto rootCgroupPath = canonPath(*cgroupFS + "/" + rootCgroup); | ||
| auto rootCgroupPath = canonPath((*cgroupFS / rootCgroup).native()); |
Contributor
There was a problem hiding this comment.
This should be something like:
auto rootCgroupPath = canonPath((*cgroupFS / std::filesystem::path(rootCgroup).relative_path()).native());
artemist
added a commit
to artemist/nix
that referenced
this pull request
Jan 5, 2026
A commit in NixOS#14800 broke tests around creating cgroups due to incorrect path handling logic. (See https://hydra.nixos.org/build/318367985/nixlog/11) Fix that logic and represent cgroups as CanonPath. Co-authored-by: John Ericson <[email protected]> Co-authored-by: Sergei Zimmerman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since it is currently unix-only, we can use
.native()not.string()for perf, and we don't have to worry about platform-specific conversions.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.